Skip to content

Remove n_jobs=-1 from curation tests#4449

Merged
alejoe91 merged 2 commits intoSpikeInterface:mainfrom
chrishalcrow:try-default-njobs-curation-tests
Mar 17, 2026
Merged

Remove n_jobs=-1 from curation tests#4449
alejoe91 merged 2 commits intoSpikeInterface:mainfrom
chrishalcrow:try-default-njobs-curation-tests

Conversation

@chrishalcrow
Copy link
Copy Markdown
Member

@chrishalcrow chrishalcrow commented Mar 16, 2026

Locally, the curation tests run 50% faster when n_jobs=1 rather than n_jobs=-1. Testing to see if this is true on our CI too.

RESULTS:

OS n_jobs=-1 n_jobs= 1
Mac 3.10 68.55 63.08
Win 3.10 208.2 101.7
Linux 3.10 96.21 98.35
Mac 3.13 76.08 43.4
Win 3.13 158.13 72.2
Linux 3.13 68.37 73.4

I vote to merge the PR!

@chrishalcrow chrishalcrow added the testing Related to test routines label Mar 16, 2026
Copy link
Copy Markdown
Member

@alejoe91 alejoe91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alejoe91 alejoe91 merged commit 37ff412 into SpikeInterface:main Mar 17, 2026
20 of 21 checks passed
@chrishalcrow chrishalcrow deleted the try-default-njobs-curation-tests branch March 17, 2026 08:16
@samuelgarcia
Copy link
Copy Markdown
Member

C'est terrible!
We need to revisit the paralleisation!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Related to test routines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants